Add commands for column marks

qwerky
Posts: 172
Joined: 21.10.2013 00:58

Post by qwerky »

Alexey wrote:Release 1.15 is done. Pls test. Other options not changed (margin, col marks plugin etc); IMO its ok as is.
Thank you. With option 2, the ruler is exactly as desired. BUT, now with column marks set 5, 10, 20, and right margin 80, the actual column lines align with ruler at 6, 11, 21, 81 -- and also align with status bar at 6, 11, 21, 81. SO, now status bar and ruler are the same--and that is great! BUT, the column lines should all be shifted one to the left. Did I explain that okay?
Alexey
Posts: 1633
Joined: 05.10.2012 22:10

Post by Alexey »

Yes, OK. i see, column lines are 0-based always. And ruler is 0-based or 1-based (by option). IMO it's ok as is.
qwerky
Posts: 172
Joined: 21.10.2013 00:58

Post by qwerky »

Alexey wrote:Yes, OK. i see, column lines are 0-based always. And ruler is 0-based or 1-based (by option). IMO it's ok as is.
Okay, I'll try to explain better. When ruler is 1-based, but columns are still 0-based, then with columns 5, 10, 20, 80 we get this:

Code: Select all

1       5        10        15        20        80
| i i i | i i i i | i i i i | i i i i | i ... i | i
          |         |                   |         |
          |         |                   |         |
          #         |                   |         |
Col 6, Ln 20 (20)
So the status bar matches the ruler (good), but the lines are off by one. If the columns were adjusted to 1-base (when the ruler is 1-base):

Code: Select all

1       5        10        15        20        80
| i i i | i i i i | i i i i | i i i i | i ... i | i
        |         |                   |         |
        |         |                   |         |
        #         |                   |         |
Col 5, Ln 20 (20)
Hope that makes sense? :D
Alexey
Posts: 1633
Joined: 05.10.2012 22:10

Post by Alexey »

hm, I suggest that for column marks, you set "4 9 19" then it will be 1-based "5 10 20", columns will match.
qwerky
Posts: 172
Joined: 21.10.2013 00:58

Post by qwerky »

Alexey wrote:hm, I suggest that for column marks, you set "4 9 19" then it will be 1-based "5 10 20", columns will match.
I had thought of that, but hesitated to mention it in my previous post. The reason is that it would work fine for "column marks", but not so good for the "right margin," because the right margin has to be set at 80 if, for example, the user wants to have "wrap" etc. occur at that point. I know it seems a small thing; and I do appreciate all the work you developers are putting into this! :D
Alexey
Posts: 1633
Joined: 05.10.2012 22:10

Post by Alexey »

sorry, I don't understand. Why you cannot set col marks to "4 9 19".

ps. Comment to you viewtopic.php?f=20&t=1846
qwerky
Posts: 172
Joined: 21.10.2013 00:58

Post by qwerky »

Alexey wrote:sorry, I don't understand. Why you cannot set col marks to "4 9 19".
Yes, one could set column marks at 4, 9, 19 in order to have them appear at 5, 10, 20.
BUT... if you set the right margin at 79 (in order to have it appear at 80), then wrapping (and other functions that depend on right margin) is going to occur at 79 instead of what the user wanted, which was 80. Does that make sense? ;)

Is there a problem with adjusting the column marks and right margin to 1-base, when 1-base is selected for the ruler?
Alexey
Posts: 1633
Joined: 05.10.2012 22:10

Post by Alexey »

It makes sense. yes, it is the problem to adjust both options: ruler + right-margin. ruler changes, r-margin dont change.
qwerky
Posts: 172
Joined: 21.10.2013 00:58

Post by qwerky »

Alexey wrote:It makes sense. yes, it is the problem to adjust both options: ruler + right-margin. ruler changes, r-margin dont change.
Hmmm, not sure I understand exactly what you are saying. But, this isn't the highest priority, so if it's too much trouble to do now, we'll get by with it as is, and perhaps it may get done in the future. ;)
Alexey
Posts: 1633
Joined: 05.10.2012 22:10

Post by Alexey »

I mean: paint from ruler option is 0-based or 1-based; paint of right-margin is always the same. (Need to change it like ruler? not sure its good)
Post Reply