Keyboard column selection broken.

[main Alexey]

I found the code which was changed.
atsynedit/atsynedit_cmd_handler.inc

Code: Select all

    cCommand_KeyLeft_Sel:
      begin
        {
        if OptMouseColumnSelectionWithoutKey then
          Result:= DoCommand_SelectColumnToDirection(TATEditorSelectColumnDirection.Left)
        else
          Result:= DoCommand_KeyLeft(true);
          }
         OptMouseColumnSelectionWithoutKey:= false;
         Result:= DoCommand_KeyLeft(true);
       end;

    cCommand_KeyRight:
      Result:= DoCommand_KeyRight(false);
    cCommand_KeyRight_Sel:
      begin
        {
        if OptMouseColumnSelectionWithoutKey then
          Result:= DoCommand_SelectColumnToDirection(TATEditorSelectColumnDirection.Right)
        else
          Result:= DoCommand_KeyRight(true);
          }
        OptMouseColumnSelectionWithoutKey:= false;
        Result:= DoCommand_KeyRight(true);
      end;  

the multiline comments {...} are old work which worked for you, I guess. the code after comment
>> OptMouseColumnSelectionWithoutKey:= false
is turning OFF that option. why it was changed? to fix some UI for some users.

[qwerky]

So, I'm still not getting it. I use shift-alt-down, now I have two carets. Now shift-right selects one column to the right. But if shift-down, column mode is canceled.

What we need (as it was before), is a way to move UP/DOWN/LEFT/RIGHT while making column selection. Is this no longer possible?

[main Alexey]

This is no longer possible - to press Arrows without SHIFT/ALT and make column selection. it's possible with the mouse of course.

[qwerky]

No, I do not mean to use arrows without shift/alt. The way it was before, you still need to use shift with arrow keys, but when in column selection mode, using shift with arrow keys would select column. When not in column selection mode, then using shift with arrow keys would make regular selection.

So, is there now, any way to make column selection using only keyboard (not mouse)? That is, to be able (with keyboard), to move Up/Down/Left/Right (whether with shift, or alt, or whatever) to make column selection?

[main Alexey]

There is no way now to do it.
I shown the code which was changed
https://synwrite.sourceforge.net/forums ... 456#p21456

Now, we need to use Shift+Alt+Down, then Shift+Right (without any mode)

[qwerky]

Understood that you are saying that there is no longer any column selection mode (so then, what effect does that toggle have, other than changing the icon in the status bar?).

So are these keys in the CommandPalette (column select: up/down/left/right) supposed to be the replacement? And can they be used in any order, anywhere in the text (such as past the end of the line)?

[main Alexey]

>what effect does that toggle have, other than changing the icon in the status bar?

The same effect as clicking on the statysbar cell '-', it changes MOUSE selection mode. I now renamed that 3 CmdPalette commands

'column selection without key modifier....'
to
'mouse column selection without key modifier....'

> these keys in the CommandPalette (column select: up/down/left/right) supposed to be the replacement?

Yes! again, first make zero-width column of carets, then Shift+Right.

> And can they be used in any order,

no, it seems (but please check it); first call Shift+Alt+Down, and then Shift+Right.

>anywhere in the text (such as past the end of the line)?

if option "caret_after_end":true, then it can be used after end.

[qwerky]

Okay, so I've assigned those four keyboard shortcuts and tested, and at least for me on the current version, they do seem to work in any position and in any order (and that's very important; don't change that).

So they do act as a replacement to a certain degree. Drawbacks, though, are that now four more keyboard shortcuts are required (which I had previously used for other functions), and also that the previous way (column mode) used all the movements, so that in column mode shift+end would extend the column selection to the end of the line, etc.

Honestly, I don't see how column selection mode could be a minus, or could negatively affect anyone. If someone didn't want to use that mode, he needn't ever turn it on. That mode could coexist side-by-side with any other way, such as with the mouse. However, if you are unwilling to re-implement that mode, then that is an end to it. I will just need to get used to doing it this other way.

[qwerky]

Several editors have a column-selection mode in the style I have been discussing: UltraEdit, Notepad++, and Geany among others, not just ConTEXT.

I'm curious as to what complaints others may have had with this mode, since you said you changed it for other users. I can't see how the mode could bother someone, since if he doesn't want the mode, he need not ever turn it on.

[main Alexey]

I am not recalling complains from other users, but maybe smth was wrong with my code (with that mode), so I reworked it. i even left the old code commented, did not remove it.