v1.113.0 and menus

[tmsg]

Hi Alexey... I'm back from the mountains in one piece... and there's a new 1.113 .

Installed it and it looks good so far... with the exception of the menus (only tested under Windows). They are now in a rather unsightly grey and the submenu triangle has turned into a plain square. See pic.

I do have created my own theme but this also seems to happen with the included themes.

EDIT: This also happens with a fresh install so it probably has nothing to do with my setup.

A relatively minor point though as I'm mostly using keyboard shortcuts...

[Alexey]

Hi again. I remember you wanted to go to climbing, seems now it's done ok. good.
What you can do -
- menu gray color is from UI theme, so just edit the theme (save with new name)
- square char is U+2BC8 so try to update OS default ui font (don't know how)

[Alexey]

MenuStyler has 3 unicode chars used- submenu (triangle), check mark "v", radio check "bullet". other 2 chars shown ok for you? see in menu with checks, with = menu. If not ok, I will replace chars to simpler ones

[tmsg]

- menu gray color is from UI theme, so just edit the theme (save with new name)
- square char is U+2BC8 so try to update OS default ui font (don't know how)

Hm... I can't say I understand that. I have nothing at all changed in my theme (I haven't touched that PC for months ) . I have just copied the new Cud files over the old install.

And I have looked into the theme definition but could not find anything obvious to do with the Menu backgound!?

As to the "OS default UI font" again I have not changed anything there so I can't see why the new version should be behaving differently.

EDIT: If I switch back to the old version it works as it ever did. So there's more to it than meets the eye.

[Alexey]

I mean you can
-open "options / settings-theme-ui" dialog
-find there item "tabs, passive tab bg"+"tabs, font" (other "tabs,....." also used)
-change them
-save theme as "tmsg" and use this theme forever.

I will fix submenu char. is "checkmark V" char (in View menu) shown ok for you?

[Alexey]

> I can't see why the new version should be behaving differently.

Coz it's using new MenuStyler!
https://wiki.freepascal.org/Win32MenuStyler

[tmsg]

> I can't see why the new version should be behaving differently.

Coz it's using new MenuStyler!

Well... IMHO that's a step back. The old menu style was apparently based on the std Windows theme: if all apps started to do their own menu themes I'd have to change the style for every single app instead of in one place to achieve a consistent look. But hey, it's your product and your call.

-open "options / settings-theme-ui" dialog
-find there item "tabs, passive tab bg"+"tabs, font" (other "tabs,....." also used)

"tabs" settings are also used for the menus? Not very obvious methinks.

Anyway, I tested this and changing the font colour works for both tabs and menu items. However, "tabs, passive tab bg" changes the passive tab bg but not the menu bg.

I will fix submenu char. is "checkmark V" char (in View menu) shown ok for you?

The bullets and checkmarks in the menus are fine. It's just the triangle.

[tmsg]

There's another problem: as you can see in the pic in my OP, the shortcut key for a menu entry is in white... the bg for the active menu choice is also white, so the shortcut key is invisible. I know I can change that (tabs mouseover) but that brings me to the second point...

which is that I do not necessarily want to have the same definition for some tab colours and the menu colours!

My take is that if you think you have to change such a central part of the UI, then please do it properly.

[Alexey]

-Changed triangle char to '>'
-Changed font color of shortcut to "tabs, font modified", it's dark blue

MenuStyler was to support dark themes, its not step back, no. it's step back only for users of default theme. I can add the option to enable menu styler, but we have too many options, lets see who don't like menu-styler...

[Alexey]

> "tabs, passive tab bg" changes the passive tab bg but not the menu bg.

It's not colored ok after Cud restart?